Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cucumber-cpp: fix test with older activesupport gem #155954

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 30, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Seen in #153108

  ==> /private/tmp/cucumber-cpp-test-20231127-66484-rodg52/bin/cucumber --publish-quiet
  /private/tmp/cucumber-cpp-test-20231127-66484-rodg52/gems/activesupport-7.1.2/lib/active_support/core_ext/time/conversions.rb:62:in `<class:Time>': undefined method `deprecator' for ActiveSupport:Module (NoMethodError)
  
    deprecate to_default_s: :to_s, deprecator: ActiveSupport.deprecator
                                                            ^^^^^^^^^^^
  Did you mean?  deprecate_constant

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Nov 30, 2023
@github-actions github-actions bot added ruby Ruby use is a significant feature of the PR or issue boost Boost use is a significant feature of the PR or issue labels Nov 30, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 30, 2023
Merged via the queue into Homebrew:master with commit fef0acd Nov 30, 2023
20 checks passed
@cho-m cho-m deleted the cucumber-cpp-test branch December 10, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles ruby Ruby use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants